frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
749 stars 217 forks source link

Bold the selected header tab text #2277

Closed claireoe closed 8 hours ago

claireoe commented 5 days ago

Changes Updated heading styling to meet the requirement of displaying the selected tab text in bold

Issue :
Bold the selected header tab text https://github.com/frzyc/genshin-optimizer/issues/2263

validation

Before

Before Changes

After

After changes
github-actions[bot] commented 4 days ago

[frontend] [Thu Jun 27 14:08:18 UTC 2024] - Deployed 1708d9c7fdfb740c5f625d9b90ca1ca45e2b29a8 to https://genshin-optimizer-prs.github.io/pr/2277/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jul 2 05:17:03 UTC 2024] - Deleted deployment

claireoe commented 4 days ago

@frzyc gone through the linked comments seems like your commit https://github.com/frzyc/genshin-optimizer/commit/d70086029888989320c608b66c11ab13f277af15 resolves the bold issue with 'Genshin optimizer' tab button ? I should focus on the other tabs sizes

frzyc commented 4 days ago

To clarify, only the selected tab in the header should be bolded, so "genshin optimizer" tab should be bolded when the user is on the home screen.