Closed 0sani closed 5 days ago
[frontend] [Mon Jul 1 10:38:47 UTC 2024] - Deployed 0d5965a7ab5250939c60acbcee8e345db9ecfe0d to https://genshin-optimizer-prs.github.io/pr/2293/frontend (Takes 3-5 minutes after this completes to be available)
[Tue Jul 2 05:18:34 UTC 2024] - Deleted deployment
Describe your changes
Changed default behavior when
tab
is null orcharacterKey
is null.When
characterKey
is null (when on team settings page), formatted as "\<Team Name> - Team Settings - Genshin Optimizer". Note thattab
will always be null in this case.When
characterKey
is not null andtab
is null, this means that we're on the "Loadout/Build" tab, so formatted appropriately.Do note that there's another issue with the Artifact Upgrader tab, where it doesn't display properly, but I'm not familiar enough with the codebase to fix this.
Issue or discord link
Testing/validation
Two of the fixed pages, and the one that's still broken, I can make another issue for that one.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.