frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
750 stars 218 forks source link

Fixed issue #2241 GO team page title shows tabs.undefined #2293

Closed 0sani closed 5 days ago

0sani commented 6 days ago

Describe your changes

Changed default behavior when tab is null or characterKey is null.

When characterKey is null (when on team settings page), formatted as "\<Team Name> - Team Settings - Genshin Optimizer". Note that tab will always be null in this case.

When characterKey is not null and tab is null, this means that we're on the "Loadout/Build" tab, so formatted appropriately.

Do note that there's another issue with the Artifact Upgrader tab, where it doesn't display properly, but I'm not familiar enough with the codebase to fix this.

Issue or discord link

Testing/validation

Two of the fixed pages, and the one that's still broken, I can make another issue for that one.

image image image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

github-actions[bot] commented 5 days ago

[frontend] [Mon Jul 1 10:38:47 UTC 2024] - Deployed 0d5965a7ab5250939c60acbcee8e345db9ecfe0d to https://genshin-optimizer-prs.github.io/pr/2293/frontend (Takes 3-5 minutes after this completes to be available)

[Tue Jul 2 05:18:34 UTC 2024] - Deleted deployment