frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
750 stars 218 forks source link

ui json change #2295

Closed k-parihar closed 2 days ago

k-parihar commented 5 days ago

Describe your changes

Added required key value pair, Nothing removed.

- "builds": "Builds"
+ "builds": "Builds",
+ "upopt" : "Artifact Upgrader"

Issue or discord link

issue#2294

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

nguyentvan7 commented 4 days ago

Sorry that fix I suggested is wrong. Can you revert your change, and instead change this https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/localization/assets/locales/en/page_character.json#L9 to be upopt as the key, instead of upgradeopt

and need to change this as well https://github.com/frzyc/genshin-optimizer/blob/87ba9f1bebd6d35c61e57c7aa03b9aba351940ba/libs/gi/page-team/src/CharacterDisplay/Content.tsx#L321

k-parihar commented 4 days ago

Hi @nguyentvan7, Reverted the previous change, added changes in

  1. https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/localization/assets/locales/en/page_character.json#L9
  2. genshin-optimizer/libs/gi/page-team/src/CharacterDisplay/Content.tsx

Please check and let me know if anything else needs to be done.

github-actions[bot] commented 3 days ago

[frontend] [Wed Jul 3 12:31:04 UTC 2024] - Deployed fa328eb6d47d063ed6b53b81dad8553f21e349f7 to https://genshin-optimizer-prs.github.io/pr/2295/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Jul 4 12:51:00 UTC 2024] - Deployed cf27b4e931f9732892921530398748108dff5a64 to https://genshin-optimizer-prs.github.io/pr/2295/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Jul 4 15:52:24 UTC 2024] - Deleted deployment

k-parihar commented 2 days ago

thanks :)