frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
788 stars 233 forks source link

Add theorycrafting mode to allow users to create different combinations of fake or standardized artifact sets #311

Closed StainAE86 closed 2 years ago

StainAE86 commented 2 years ago

Some users used to create 'fake' artifacts with useless substats to theorycraft artifact set effects and work out which artifact set they should farm for a particular character.

It used to be very easy to just edit the artifacts while they were equipped to the character they were testing to change over to and check different sets. Now you need to create 5 artifacts of each type and equip them individually or unequip, edit, re-equip making the processs tedious.

Instead of just re-enabling editing of equipped artifacts (which still could be done in the meantime?) How about making a new TC tab (enabled from under the Settings page) within the character page that allows users to set different 2pc/4pc sets and give them a certain number of allocatable rolls to allow simulating artifact set or baseline substats so users can TC standard or ideal builds for different characters in certain teams/playstyles.

I would imagine setting a artifact/substat combination under this TC tab would give you the option to compare directly to another simulated build, to your current equipped build or to any newly generated (but not yet equipped) build.

frzyc commented 2 years ago

I was planning to make a theory crafting mode where you can "build" a character based not on artifacts, but number of rolls allocations. In theory you can pair this with set effects, so this will probably fall under that...

StainAE86 commented 2 years ago

Here is a mock up of what I'm thinking.

Below that you have a secondary theory crafted build. Again you can chose to copy from your current equipped, or copy from above to quickly pre-fill so you can make minor changes for comparison purposes.

image

To expand on the usefulness of the "Copy from" feature. You could load your current build attributes into the TC Tab and then swap the weapon to something different to see a direct comparison of damage numbers in the build overview above. Or for example you may have a character built with all +16 artifacts and you want to see (on one page) how much gain you would get by raising them individually or all to +20.

image

StainAE86 commented 2 years ago

An additional idea. The TC tab could have an Import/Export feature that creates a .json of just the TC build. This could allow KQM and other guide makers to provide their "standard build" as a file users can upload to GO and compare to their account.

StainAE86 commented 2 years ago

Following on from the above comment -

Some users have suggested GO could have the option to "pre-fill" the KQM Standard for Artifact rolls into this "TC tab".

However after looking into the KQM Standard I don't believe it's compatible as it's up to the theory crafter/guide writer to decide where they assign their 20 allocatable substats - which will of course be different for every character and playstyle.

The other difficulty is the KQM Standard assumes an average roll which is not natively achievable in GO. The best GO can do is set 1x low and 1x high roll per substat which gives a comparable number.

image image

As always GO shouldn't tell people how to play or build characters - only provide them the means to make that choice for themselves.

That's why it's important that the Import/Export of any "TC build" created using this TC Tab is independent of the user's main database. This would allow people to create, share and compare theory crafted character build data against their own account.

In the end the user may find that they already have a comparable build that's different to the suggested one in a guide they read/watched which saves them weeks/months worth of resin farming an artifact set they didn't actually need.

StainAE86 commented 2 years ago

image image image