frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
789 stars 233 forks source link

Enter a UID in the database to work with Enka.Network #632

Open StainAE86 opened 2 years ago

StainAE86 commented 2 years ago

Add the ability to enter a UID to the database so GO can detect if the current character is in the showcase Use cases for this could include:

The last 2 become more helpful with Enka's latest version for patreons who can hold snapshots of all their previous showcase characters

SuperFurias commented 1 year ago

I think this should be done as soon as possible. using local scanner is potentially DANGEROUS and could result in a ban (even if they are undetectable). Sites like aspirine.su already have the import by character showcase (UID) image Please add this as soon as possible.. because genshin optimizer (little-bro) is much better than aspirine.su (UI, and has more features)

SuperFurias commented 1 year ago

PS: api here: https://api.enka.network/#/

nguyentvan7 commented 1 year ago

There have been 0 reports of bans from scanners afaik. GO operates on knowing your entire artifact inventory, so you'd need to scan every single artifact in from enka. Assuming you have 250 artifacts, that is at minimum 12.5 minutes of just waiting for enka refreshes, not to mention all of your equipped locations would be wrong. And a ton of manual input. It would probably be faster to just take screenshots and use the site scanner

Artiscan is literally undetectable as well, so I'm not sure how you would get banned for something the game has no clue you are running

SuperFurias commented 1 year ago

As i said, its potentially dangerous. AND i also specified that they are undetectable. if they warn you about the use of third party softwares, there must be a reason. even if they are virtually undetectable. hoyoverse can be evil. And, excuse me, maybe i am a ps5/xbox player, or an android player, ios player etc etc, and i don't have/use the pc, and i want a quick way to import things inside genshin optimizer. (mostly playstation and xbox players. mobile users... most of them don't really use genshin optimizers) don't just randomly throw things only by looking on the perspective of a pc player. (I am a PC player by the way) I'm not saying that the enka import should replace the scanners. because scanners can do MANY things in a way way much quicker way. but they are still limited to pc users only. but instead of running every time the scanner for each change i do inside the game, and i mostly/only use the pg in the character showcase, i would prefer to have a thing like the enka import, even as a pc player.

And a thing i like about enka, is the fact that.. you can also import your friends characters. so you can compare in a very quick way.. for example, two raiden shoguns.

nguyentvan7 commented 1 year ago

Artiscan supports consoles as well. It seems you may not be aware of what artiscan is and how it works

Artiscan just takes a video recording as input. It's an entirely separate website that you don't have to install or anything. You use whatever built in screen recording is on your phone, console or PC and record yourself clicking on all your artifacts. Artiscan will then scan that video file completely outside of the game and is LITERALLY undetectable. And video recording is clearly allowed by the game since people stream on twitch, upload gameplay to YouTube, etc

SuperFurias commented 1 year ago

Artiscan supports consoles as well. It seems you may not be aware of what artiscan is and how it works

Artiscan just takes a video recording as input. It's an entirely separate website that you don't have to install or anything. You use whatever built in screen recording is on your phone, console or PC and record yourself clicking on all your artifacts. Artiscan will then scan that video file completely outside of the game and is LITERALLY undetectable. And video recording is clearly allowed by the game since people stream on twitch, upload gameplay to YouTube, etc

i didn't know of this.

D1firehail commented 1 year ago

xbox

Genshin is not available on xbox

Having enka import for comparison/calculation aspect would be pretty convenient, same goes for minor artifact adjustments and characters. However, it's not to the level of "this should be done as soon as possible" in my opinion.

SuperFurias commented 1 year ago

xbox

Genshin is not available on xbox

sad for xbox players then. mh.. yes. after knowing of artiscan, i think this enka import feature is not that urgent as it seems. but well, a cool feature i would like, and probably use a lot. i don't really like local scanners that much. i should try this artiscan thing, if its quick enough, good.

D1firehail commented 1 year ago

(even if they are undetectable)

I should clarify that (non-artiscan) scanners are not inherently undetectable. There's just no reason for MHY to detect them, and they aren't getting picked up accidentally by the anticheat. According to my reading of the EULA, they aren't even doing anything wrong (but feel free to read the relevant parts and make your own judgement).

if they warn you about the use of third party softwares, there must be a reason

They do not want to be in any way liable for anyone using third party software, or said third party software doing anything sketchy.

They have no incentive to judge if any particular third party software is breaking their rules unless it's in order to take it down.

nguyentvan7 commented 2 months ago

https://github.com/seriaati/enka-to-go https://enka-to-go.seriaati.xyz/