frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
784 stars 233 forks source link

Changing max builds gives a different plot #649

Closed eeeqeee closed 2 years ago

eeeqeee commented 2 years ago

Change maxBuildsToShow from 1 to 2 and the plot will be different

{"format":"GOOD","dbVersion":20,"source":"Genshin Optimizer","version":1,"characters":[{"key":"Xingqiu","level":1,"ascension":0,"hitMode":"avgHit","conditional":{},"bonusStats":{},"enemyOverride":{},"talent":{"auto":1,"skill":1,"burst":1},"infusionAura":"","constellation":0,"team":["","",""],"teamConditional":{},"compareData":false,"customMultiTarget":[]}],"artifacts":[{"setKey":"BlizzardStrayer","rarity":5,"level":0,"slotKey":"flower","mainStatKey":"hp","substats":[{"key":"enerRech_","value":6.5},{"key":"eleMas","value":23},{"key":"def","value":23},{"key":"def_","value":7.3}],"location":"","exclude":false,"lock":false},{"setKey":"BlizzardStrayer","rarity":5,"level":0,"slotKey":"flower","mainStatKey":"hp","substats":[{"key":"def_","value":7.3},{"key":"hp_","value":5.8},{"key":"def","value":23},{"key":"eleMas","value":23}],"location":"","exclude":false,"lock":false}],"weapons":[{"key":"DullBlade","level":1,"ascension":0,"refinement":1,"location":"Xingqiu","lock":false}],"buildSettings":[{"artSetExclusion":{},"statFilters":{},"mainStatKeys":{"sands":[],"goblet":[],"circlet":[]},"optimizationTarget":["basic","atk"],"mainStatAssumptionLevel":0,"useExcludedArts":false,"useEquippedArts":false,"allowPartial":true,"builds":[["artifact_0"]],"buildDate":-1,"maxBuildsToShow":1,"plotBase":"enerRech_","compareBuild":true,"levelLow":0,"levelHigh":20,"key":"Xingqiu"}]}
frzyc commented 2 years ago

Yeah, the graphs are generated from the builder running through the build candidates. when you have different maxbuilds, you have different number of builds to run through due to pruning. This is... 100% intended?

eeeqeee commented 2 years ago

I interpreted the plot as running through all possible builds not just candidates since the max builds selector is next to the thread count so I assumed that both selectors didn't affect the results shown Taking into consideration the plotted stat would probably slow down pruning a lot without much benefit and this shouldn't really affect most results since for most builds getting more of the plotted stat is fine (I think Mistsplitter and Thundering Pulse are the only exceptions to the monotonicity of damage)