search

frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
790 stars 234 forks source link

RV Filter behavior is inconsistent with other filters #718

Closed nguyentvan7 closed 1 year ago

nguyentvan7 commented 2 years ago
image

If I were to click the "3 star" filter for artifacts here, then 3-star would be the only one selected. Then I could click "4-star" if I wanted both 3 and 4 stars to appear.

However, if I click Elemental Mastery for the RV filter, then everything bug Elemental Mastery will be selected

I also wonder if this should turn into an autocomplete, similar to substat filter?

frzyc commented 2 years ago

probably will cause more problems for end-user than any provide any soothing to your OCD. close yer eyes, take a deep breath, and look at our other glaring issues.

Alternative is to make this element fundamentally not a button group,

or include [] [x] toggles before the buttons(remove the text)

nguyentvan7 commented 2 years ago

Not really OCD, it's just inconsistent behavior that makes it confusing to use (aka is an end user problem)

frzyc commented 2 years ago

Then like I said, you either make it not a buttongroup, or denote toggles, or redesign this element altogether. I am not sure autocomplete is a good idea in this regard, since I would want a UI element that shows both: all the options, and which elements are selected.