Closed gendoh closed 1 year ago
That's because the constraints are strickly greater than the value you enter. not equal to or greater than
Since 400% is the maximum dmg bonus - you can never achieve more than 400
Think this is some floating point shenanigans. Balakin tested setting an ER min of 100, and builds would still appear just fine. could add some epsilon/fuzzy checking. But I also havent looked into this really, so could be something else
FYI, with complex data & condition, sometimes 400% is working and sometimes not.
When I set all of 1,2 and 3, no build. but when I set 2&3 or 1&3, build is generated.
Of course, current equipment is met with all conditions.
@StainAE86 If "constraints" does not include "equal", working case in my previous comment will be a bug.
I think that constraints are minimum values for builds. So, I expect "equal" is included.
If "equal" is really not included and constraints means just "greater", I think tooltip should be changed. Also, I should fix the Korean translation for it - Korean has explicit words for each "gt" and "eq or gt" case, and I used a word for the later case.
Could you confirm it?
I can't 100% confirm it because I don't know the code. It could infact be greater than or equal to. But I'm pretty confident it's because the "400%" you're seeing in your build isn't actually 400% due to rounding. So because of that you can't trust a whole number and have to always consider that its strictly "greater than".
Like this case from your database file: You can increase the HP constraint on your build to 75345.22 before the build is not returned. Since the "75345" is rounded down in thise case.
And if I remove 917 HP from your build to drop your DMG Bonus to 399.9%:
I then have to set the constraint to 399.85% to make the build appear since even tho it's "displaying" at 399.9%, its probably 399.86% rounded up behind the scenes:
It would seem that the constraint of "400%" is actually considered a higher number than the maximum possible DMG Bonus of "400%" if that makes sense.
So even tho your build has more than 400% - because it's being limited to a maximum "400%" that is below the constraint of "400%". That's why it works if you put the constraint as "399.9%" because the maximum "400%" is larger than that.
When "Dreamy Dance of Aeons's Bloom DMG Bonus" is set to 400% for build constrains, any build is not generated.
Version : 8.28.1
Party : Nahida, Kokomi, Collei - all are just created aka. level 1, default weapon, no aritifacts.
Nilou : C6 Lvl 90. 9/12/12
Build target : Transformative Reactions Bloom DMG
Without any constrains, build with HP 75K is generated
When set Bloom DMG bonus to 400% for build constraints, no build is generated.
When set to 399.9,% it's working.
Below code is a database backup for testing.