frzyc / genshin-optimizer

An Artifact optimizer for Genshin Impact.
https://frzyc.github.io/genshin-optimizer/
MIT License
770 stars 226 forks source link

Show more graph points per x-value #819

Open MrPillow1 opened 1 year ago

MrPillow1 commented 1 year ago

Currently, the Optimization Target vs. the selected Graph Target graph shows only the maximum Optimization Target value per 0.01 of the selected Graph Target. This makes it so that important builds can't be seen on the graph, effectively hiding away useful information. For example, when I graph my damage vs. ER, only the first of my two top builds (which happen to have the same ER) is shown on the graph. Considering my 2nd best build is a very important build, it's weird that it isn't shown on the graph, while worse builds are shown.

However, I'm also aware that showing all y-values for a given x-value is unreasonable, since there can be thousands or more such builds, which would crash the graph. Therefore, I'm suggesting that if a build is in, say, top 15 of your optimization results, they should all be shown on the graph regardless of some of the builds sharing the same x-value. Alternatively, the top, say, 3 builds can be shown on the graph per 0.01 Graph Target (though I'm (merely) guessing that this is much harder to implement and resource-intensive).

nguyentvan7 commented 1 year ago

Rewording this so that instead of showing 3 y-values per x-value, we will just add the highlighted builds to the graph after generating

MrPillow1 commented 1 year ago

oh well. saw the reasoning in the pr. it's fine ig.

nguyentvan7 commented 1 year ago

We could add the 3-per-x as well, I just thought your original post was looking to see the generated builds on the graph always.

nguyentvan7 commented 1 year ago

I'll change this back to 3-per-x and create another issue for always adding highlighted builds to graph post-fact