fs / rails-base-graphql-api

Base Rails application for GraphQL API
27 stars 7 forks source link

Update docker config #200

Closed EvgeniyEsaulkov closed 2 years ago

EvgeniyEsaulkov commented 2 years ago

Summary

This PR updates docker configuration a bit:

References

EvgeniyEsaulkov commented 2 years ago

If you follow installation instructions it will fail

To reproduce run:

# Required if you already have the project installed
docker volume rm rails-base-graphql-api_db-data \
                 rails-base-graphql-api_ruby-bundle

bin/docker-setup
bin/tests
bin/quality

Why do you run docker-setup and then use scripts without docker?

DmitryBarskov commented 2 years ago

@EvgeniyEsaulkov sorry, I meant the scripts with docker- prefix

Here is the right variant to reproduce the problem:

# Required if you already have the project installed
docker volume rm rails-base-graphql-api_db-data \
                 rails-base-graphql-api_ruby-bundle

bin/docker-setup
bin/docker-tests
bin/docker-quality

After this I have all tests failed because there is no database set up.

DmitryBarskov commented 2 years ago

I suppose that means that we have to leave bin/docker-setup unchanged

EvgeniyEsaulkov commented 2 years ago

I suppose that means that we have to leave bin/docker-setup unchanged

It doesn't depend on docker-setup - error during tests appears in both old and new versions of this file. docker/quality works well for me with both versions.

What do you think if we run db:schema:load before running tests like we do it on Semaphore CI?