fs / rails-base

Skeleton for new Rails based projects.

http://www.flatstack.com/open-source/

198 stars 57 forks source link

Use sassc instead of sass-ruby #616

Closed DmitryBarskov closed 3 years ago

DmitryBarskov commented 3 years ago

Summary

Replaced sass-rails with sassc-rails.

Reopening of #600. Resolves #541.

Review notes

While reviewing pull-request (especially when it's your pull-request), please make sure that:

you understand what problem is solved by PR and how is it solved
new tests are in place, no redundant tests
DB schema changes reflect new migrations
newly introduces DB fields have indexes and constraints
routes are RESTful, no useless routes
there are no missed files (migrations, view templates)
required ENV variables added and described in .env.example and added to Heroku
associated Heroku review app works correctly with introduced changes

Deploy notes

Notes regarding deployment the contained body of work. These should note any db migrations, ENV variables, services, etc.

EvgeniyEsaulkov commented 3 years ago

@DmitryBarskov what do you think if we willn't switch from rails-sass to sassc-rails but just update the gem we used before. As I can see here this gem uses sassc-rails from the version 6.0.0