fsalum / puppet-redis

Redis Server Module for Puppet
Apache License 2.0
20 stars 68 forks source link

the redis_version fact isn't always accurate on the first Puppet run. #37

Closed tmclaugh closed 10 years ago

tmclaugh commented 10 years ago

It's calculated at the start of the run which can be problematic when a package repo is introduced during the run containing a newer Redis version or no Redis package was available at the start of the run. In the first case the fact will assume the lower version but during the run after realizing a package repo containing a newer version a file resource just set 'ensure => present' will install the later version and result in a mismateched config file. In the second sccenario redis_version will be nil and result in a blank config file.

This change will:

cc. @streed

tmclaugh commented 10 years ago

I'm open to alternatives for doing this better. It's kludgy but it makes this work on the first run in our environment where we have an internal repo with a newer version.

fsalum commented 10 years ago

looks good to me, I will test later and bump the version to forge.