fsalum / puppet-redis

Redis Server Module for Puppet
Apache License 2.0
21 stars 68 forks source link

BUGIFX: duplicate entry for "/var/log/redis/redis-server.log" #5

Closed arthurfurlan closed 11 years ago

arthurfurlan commented 11 years ago

This change fixes the error "Duplicate entry for /var/log/redis/redis-server.log" caused because both the module and debian package add different logrotate files for "redis-server". (fix #4).

fsalum commented 11 years ago

@arthurfurlan is /etc/logrotate.d/redis by default in any distribution ? If not we can remove that 'absent' file resource about it, right ? just keep the one that is present.

fsalum commented 11 years ago

I did a small change and I set the logrotate file different per OS in params.pp.

  file { $conf_logrotate:
    path => $conf_logrotate,
    content => template('redis/redis.logrotate.erb'),
    owner => root,
    group => root,
    mode => '0644',
  }
arthurfurlan commented 11 years ago

Great! :)