Check if kibit is disabled before running it

fsantiag / sonar-clojure

A SonarQube plugin to analyze Clojure source.

MIT License

58 stars 27 forks source link

Check if kibit is disabled before running it #25

Closed Juholei closed 5 years ago

Juholei commented 5 years ago

Disabling kibit with sonar.clojure.kibit.disabled=true did not work, as it was started before checking whether it was disabled. Moved the run command inside the if clause that checks whether kibit is disabled.

Juholei commented 5 years ago

Hello, any comments on this pull request? As far as I can tell, the CI build failing was not because of my changes.

fsantiag commented 5 years ago

Hi @Juholei, thank you for your contribution and sorry for the late reply!

Yes, indeed the CI is breaking for another reason. Don't worry about that now. I am going to fix it. Could you add a test to that bug you found? It would be nice to have that covered.

fsantiag commented 5 years ago

Nevermind @Juholei, since it is a simple change I will add the test for that. I am working in a small refactoring at the moment.

Thanks.