fsantini / KoboCloud

A set of scripts to synchronize a kobo reader with popular cloud services
Other
958 stars 94 forks source link

Replace curl completely with rclone #163

Open marklar423 opened 9 months ago

marklar423 commented 9 months ago

This PR is similar to #35, but goes much further to completely remove curl as a dependency and use rclone instead.

Here's what I did:

I've built a newKoboRoot.tgz and have been using it on my device (Kobo Libra 2) to sync my Google Drive - it appears to be working well.

This is a big departure from the way things work now, but I think it brings massive improvements that make it worth it:

Please let me know your thoughts - I'm happy to discuss further and make changes.

marklar423 commented 9 months ago

Update: I've also updated get.sh to put files for each remote in a separate subdirectory, to avoid the issue where sync (i.e. REMOVE_DELETED) removes files from other remotes, as mentioned in https://github.com/fsantini/KoboCloud/pull/35#issuecomment-738173251.

marklar423 commented 9 months ago

For testing, I've made a release here https://github.com/marklar423/KoboCloud-rclone/releases/tag/latest

fsantini commented 9 months ago

Hi, thanks a lot for all your work! As this changes a lot regarding the internals of KoboCloud, I would support having it as a separate project. I am willing to give it prominence in the readme file so people can be redirected to this version, but replacing the existing workflow would disrupt too many current users, I believe (including me).

marklar423 commented 8 months ago

Hey @fsantini thanks for taking the time to look at my PR. I totally get where you're coming from, this would definitely be a big change for existing users. So, I'll keep my fork maintained, and you can close this as obsolete or wontfix if you like.

thocou commented 5 months ago

Hi @marklar423 i tried your fork after resetting the factory state of my Kobo Aura 2. It works perfectly, thanks a lot to both of you ! The only issue that i have is that i see no books covers - looks like #136 Is there any way i could help you with this topic, maybe in providing logs ?