fsantini / KoboCloud

A set of scripts to synchronize a kobo reader with popular cloud services
Other
1.01k stars 97 forks source link

[RFE] Build/use rclone #34

Open ScottESanDiego opened 4 years ago

ScottESanDiego commented 4 years ago

This works great, thanks for putting this together!

Unfortunately we have curl getting the file every time (we should look at using -z in curl to compare against the old file time), and limited support for cloud sources.

Updating to use rclone would allow more diverse support of sources, as well as authenticated support. E.g., have a user create an rclone config file, then copy it over to kobo.

(Assumes the EABI5 arm rclone binary works, or one is made with a working golang)

Reference: https://rclone.org/

ScottESanDiego commented 4 years ago

See PR35.

fsantini commented 4 years ago

Hi Scott! Great improvement, indeed rclone seems the way to go, it would solve a lot of maintenance problems. I suggest we don't try to implement rclone alongside the current curl, but we make a new branch and eventually replace the whole package with the rclone version.

ScottESanDiego commented 4 years ago

Yeah, I too think that just ripping it all out and using rclone is the real right answer, but I didn't want to get that radical in the PR and break everyone already using kobocloud. It certainly would simplify things though!