search

fsantini / python-e3dc

Python API for querying E3/DC systems through the manufacturer's portal
MIT License
71 stars 23 forks source link

Add new Tag 0x0100003E, manual charging last target energy #117

Closed torbennehmer closed 1 month ago

torbennehmer commented 2 months ago

Sending EMS_REQ_GET_MANUAL_CHARGE uncovers a new, unknown tag with value 0x0100003E. According to my current analysis, this will yield the last target energy level in Wh used for manual charging. With this fix, pye3dc will now correctly give you a response to this REQ again:

[
  [
    "EMS_MANUAL_CHARGE_ACTIVE",
    "Bool",
    false
  ],
  [
    "EMS_MANUAL_CHARGE_START_COUNTER",
    "Int64",
    1713369791878
  ],
  [
    "EMS_MANUAL_CHARGE_ENERGY_COUNTER",
    "Double64",
    10.10137
  ],
  [
    "EMS_MANUAL_CHARGE_LASTSTART",
    "Timestamp",
    1713369791.87892
  ],
  [
    "EMS_MANUAL_CHARGE_LASTTARGET",
    "Uint32",
    10
  ]
]

I hope that tag name is OK, if not, let me know, then I'll change it.

fixes #109

torbennehmer commented 1 month ago

@fsantini Do you need anything else here? I'd be glad to update the PR if you just drop me a hint what you're missing!

fsantini commented 1 month ago

Thanks! Sorry for not being responsive, too busy with many things! :)