fsantini / python-e3dc

Python API for querying E3/DC systems through the manufacturer's portal

MIT License

71 stars 23 forks source link

S10 fixes #74

Open torbennehmer opened 1 year ago

torbennehmer commented 1 year ago

A number of fixes done for my HA integration to work cleanly.

fixes #73:

S10E Serial number detection did not work, a missing elif masked the corresponding check
A few exported classes were missing (notably SendError for error detection)
Calls to set_power_save and set_weather_regulated_charge were not correctly parsing the results from E3DC. (Did some code streamlining to those functions on the way)

torbennehmer commented 1 year ago

@vchrisb I have just created another PR without the changes around weather regulated charging. That should allow you to move on, while we get to the bottom of this here :)

75 open

torbennehmer commented 10 months ago

@vchrisb How should we continue here, I still think we have some different behviour here depending on unit type. If this is easier for you, we could also take this discussion offline and do it in German language.

eikowagenknecht commented 9 months ago

If you need to test with yet another device (S10 X Compact 14), feel free to contact me :-)