fsantini / python-e3dc

Python API for querying E3/DC systems through the manufacturer's portal
MIT License
71 stars 23 forks source link

Fix error in voltages field #96

Closed eikowagenknecht closed 8 months ago

eikowagenknecht commented 8 months ago

Unfortunately in #86 there was a small problem that led to the "voltages" field containing an error message instead of being empty. This renames the problematic variables so it's clearer what the code does and the voltages object stays empty.

Old:

    "dcbs": {
      "0": {
        "current": null,
        "currentAvg30s": -0.4657486081123352,
        "cycleCount": null,
        "designCapacity": null,
        "designVoltage": null,
        "deviceName": null,
        "endOfDischarge": null,
        "error": null,
        "fullChargeCapacity": null,
        "fwVersion": null,
        "manufactureDate": null,
        "manufactureName": null,
        "maxChargeCurrent": null,
        "maxChargeTemperature": null,
        "maxChargeVoltage": null,
        "maxDischargeCurrent": null,
        "minChargeTemperature": null,
        "parallelCellCount": null,
        "sensorCount": 0,
        "seriesCellCount": 0,
        "pcbVersion": null,
        "protocolVersion": null,
        "remainingCapacity": null,
        "serialCode": null,
        "serialNo": null,
        "soc": null,
        "soh": null,
        "status": null,
        "temperatures": [],
        "voltage": null,
        "voltageAvg30s": 392.5743408203125,
        "voltages": [
          "BAT_DCB_ALL_CELL_VOLTAGES",
          "Error",
          "RSCP_ERR_OUT_OF_BOUNDS"
        ],
        "warning": null
      }
    },

New:

  "dcbs": {
    "0": {
      "current": null,
      "currentAvg30s": -0.5459553003311157,
      "cycleCount": null,
      "designCapacity": null,
      "designVoltage": null,
      "deviceName": null,
      "endOfDischarge": null,
      "error": null,
      "fullChargeCapacity": null,
      "fwVersion": null,
      "manufactureDate": null,
      "manufactureName": null,
      "maxChargeCurrent": null,
      "maxChargeTemperature": null,
      "maxChargeVoltage": null,
      "maxDischargeCurrent": null,
      "minChargeTemperature": null,
      "parallelCellCount": null,
      "sensorCount": 0,
      "seriesCellCount": 0,
      "pcbVersion": null,
      "protocolVersion": null,
      "remainingCapacity": null,
      "serialCode": null,
      "serialNo": null,
      "soc": null,
      "soh": null,
      "status": null,
      "temperatures": [],
      "voltage": null,
      "voltageAvg30s": 392.34014892578125,
      "voltages": [],
      "warning": null
    }
  },
vchrisb commented 8 months ago

PR needs to be updated.

eikowagenknecht commented 8 months ago

@vchrisb done