search

fsantini / python-e3dc

Python API for querying E3/DC systems through the manufacturer's portal
MIT License
71 stars 23 forks source link

Fix RscpType typos in set_power_limits #99

Closed torbennehmer closed 8 months ago

torbennehmer commented 8 months ago

Fixes #98

vchrisb commented 8 months ago

Thank you. I think UInt32 would actually make more sense, but lets fix the bug first and maybe to renaming later.

torbennehmer commented 8 months ago

Thank you. I think UInt32 would actually make more sense, but lets fix the bug first and maybe to renaming later.

Thanks for merging and releasing quickly! I'll push out a new hacs release in a minute.

Yeah agreed. If you rename an ENum like that in the future, it would be great if you could drop a "breaking change" hint in your release notes, as I've got a few implemented direct calls at this time, so that I can adapt my code as well.

vchrisb commented 8 months ago

It was Uint32 also before the enum change: https://github.com/fsantini/python-e3dc/blob/09f215a3e5f65a1665f1292dfe0a4af4a06514ad/e3dc/_rscpTags.py#L2079