fsasvari / laravel-trailing-slash

Adds redirection with trailing slash in Laravel.
MIT License
58 stars 17 forks source link

Signed URL's fail #37

Open luttje opened 3 years ago

luttje commented 3 years ago

Thanks for the great package, it works great for my products. Just a minor bug I found

This is related to #16

All signed urls fail. Would be great if this could be handled somehow.

The problem is that the route url returned by Illuminate\Routing\UrlGenerator@toRoute doesn't return a trailing slash. Therefor the signature is the url encrypted without a trailing slash in sha256. Later when I try to validate the url the request actually does have a trailing slash. Meaning the comparison fails.

PR #24 would provide a temporary workaround.

furiousjayed commented 3 years ago

guys need help on this issue

StreetYo commented 2 years ago

41 Should fix the error with signature.