fsavje / math-with-slack

Rendered math (MathJax) with Slack's desktop client
MIT License
431 stars 62 forks source link

Wrong Windows directory picked for installation #17

Closed gauss256 closed 7 years ago

gauss256 commented 7 years ago

The installer sorts the candidate installation directories by name, but due to the way Slack updates itself, this can lead to the wrong directory being chosen.

For example, on my system I have

2017-06-07  09:31 PM    <DIR>          app-2.6.3
2017-06-02  07:19 PM    <DIR>          app-2.6.3-beta2622578f

The installer picks app-2.6.3-beta2622578f for SLACK_DIR but it should use app-2.6.3 because it is more recent.

You can workaround this by specifying the Slack directory on the command line. I'll do a pull request with a suggested fix.

fsavje commented 7 years ago

Fixed with #18