fsavje / math-with-slack

Rendered math (MathJax) with Slack's desktop client
MIT License
431 stars 62 forks source link

Stopped working in Slack Version 3.2.0? #36

Closed KilianMichiels closed 6 years ago

KilianMichiels commented 6 years ago

Hi,

I used your script for quite some time now and it always worked fine. But now, since a week or so, it's just not rendering anymore. I'm not sure if it's the new Slack version (I have v3.2.0 installed)? I already tried everything like downloading the script again from the Github, re-running the script and checking with some basic math that should normally work.

Thanks in advance for any help!

LaurentHayez commented 6 years ago

Hi Kilian,

Me and another user both have this issue with Slack v3.2.0 (and now 3.2.1) on Ubuntu 18.04. Do you also use Ubuntu 18.04 or do you use another OS?

KeAWang commented 6 years ago

It doesn't work on Windows 10 with Slack v3.2.0 either

KilianMichiels commented 6 years ago

Hi Laurent,

I'm using MacOS High Sierra (latest version).

fsavje commented 6 years ago

Hi @Michielskilian and thanks for the bug report. Please try this script: https://github.com/fsavje/math-with-slack/releases/download/v0.2.4/math-with-slack.sh Please let me know how it works.

(Working on Windows version at the moment, @KeAWang )

fsavje commented 6 years ago

@KeAWang Could you please try whether the updated script works, and report back to here?

KilianMichiels commented 6 years ago

Hi @fsavje, the script you attached works!

Thank you for the quick fix!

Servinjesus1 commented 6 years ago

Unfortunately the newest version is not working for me in Win10, v3.2.0 image A few of the paths aren't working even though the .js files are in the directory. The previous release, v0.2.3 runs without a hitch but none of the math is rendering either way...

KeAWang commented 6 years ago

@fsavje It still doesn't seem to work on Windows 10. The new script gives the following errors

Using Slack installation at: ...\slack\app-3.2.0\resources\app.asar.unpacked\src\static
The system cannot find the path specified.
FINDSTR: Cannot open ...\slack\app-3.2.0\resources\app.asar.unpacked\src\ssb-interop.js
The system cannot find the path specified.
FINDSTR: Cannot open ...\slack\app-3.2.0\resources\app.asar.unpacked\src\ssb-interop.js
Backup already exists: ...\slack\app-3.2.0\resources\app.asar.unpacked\src\static/ssb-interop.js.mwsbak
Press any key to continue . . .
fsavje commented 6 years ago

@Servinjesus1 and @KeAWang Thanks for trying it out. I don't have access to a Windows machine atm, so I can't debug this properly. Could you try this script: https://raw.githubusercontent.com/fsavje/math-with-slack/7d7bc39d2723e8c299bff47d4d80d465d044a1af/math-with-slack.bat Thanks!

KeAWang commented 6 years ago

Works great now, thanks!

fsavje commented 6 years ago

Thanks for checking!