search

fsavje / math-with-slack

Rendered math (MathJax) with Slack's desktop client
MIT License
431 stars 62 forks source link

Installer fails to patch ssb-interop.js on OS X Sierra #37

Closed robertomon closed 6 years ago

robertomon commented 6 years ago

I resorted to manually editing ssb-interop.js and adding the lines

var mwsp = path.join(__dirname, 'math-with-slack.js').replace('app.asar', 'app.asar.unpacked');
require('fs').readFile(mwsp, 'utf8', (e, r) => { if (e) { throw e; } else { eval(r); } });

before the last start() function call, this seems to do the trick.

The installer script doesn't print any error. I had some doubts about permission problems with sudo, but the issue seems to be with the ed line instead (I think), because I tried to run the script pointing to a copy of ssb-interop.js owned by my user and it had no effect on it. I'm not familiar with the ed syntax but I suspect the first line starting with slash (/init...) is searching for that string? I've noticed that my version of ssb-interop.js has no such string. I'm using the client version 2.8.1 App Store.

fsavje commented 6 years ago

Thanks for the report @robertomon. The current version of math-with-slack works with the latest version of Slack (i.e., 3.2.0). For prior Slack versions, please use math-with-slack v0.2.3.

robertomon commented 6 years ago

Thanks, not sure why my App Store wasn't marking Slack as needing an update!