Packaging improvements - Githubissues

fscheck / FsCheck

Random Testing for .NET

https://fscheck.github.io/FsCheck/

BSD 3-Clause "New" or "Revised" License

1.15k stars 154 forks source link

Packaging improvements #664

Closed kurtschelfthout closed 4 months ago

kurtschelfthout commented 4 months ago

With the recent changes in deploy, I believe we are in a good position to modernize FsCheck packaging.

[ ] Enable source linking
[ ] Enable deterministic build
[ ] Check if we can include compiler flags (not sure fsc does that)

Imo source linking is pretty useful. It used to be enabled but it bitrotted, I think it's much more standardized now.

Goal would be to have a squeky clean Nuget package explorer health check. Currently looks like this:

Smaug123 commented 4 months ago

I'm looking at sourcelink now. (I need to get round to it for my own packages anyway.)

Smaug123 commented 4 months ago

SourceLink is implicit in the net8 SDK, so I'm now trying to find out what sources it thinks are untracked. (I can't run the NuGet package explorer, of course, because it's a global tool and I'm not installing the net6 runtime.)

kurtschelfthout commented 4 months ago

This may help

Smaug123 commented 4 months ago

To my great surprise, there is no public way of reading SourceLink metadata?! (Maybe this is not to my surprise, because this is MsBuild we're talking about.)

Smaug123 commented 4 months ago

I'm not convinced that EmbedUntrackedSources is what we want (at least, I'm not convinced until I can know what those untracked sources are).

Smaug123 commented 4 months ago

Before working out that mystery, I've pulled out https://github.com/fscheck/FsCheck/pull/670 for just the deterministic builds bit.

Smaug123 commented 4 months ago

The compilation options thing is not supported in F# (https://github.com/dotnet/fsharp/issues/12002).

Smaug123 commented 4 months ago

To summarise:

Deterministic builds and SourceLink are now working (as you noted in https://github.com/fscheck/FsCheck/pull/670#issuecomment-1963022094), modulo a bug in the F# compiler and a bug in the interaction between MsBuild and the compiler.
Compilation options are not supported.

I think this ticket can be closed, because it's as complete as it's practical to be.