search

fscheck / FsCheck

Random Testing for .NET
https://fscheck.github.io/FsCheck/
BSD 3-Clause "New" or "Revised" License
1.15k stars 154 forks source link

Deterministic builds #670

Closed Smaug123 closed 4 months ago

Smaug123 commented 4 months ago

Ref: #664

Works for me in the sense that the resulting nupkg lets me "go to definition" in Rider and I see the F# source. I'll do the same check with the nupkgs that AppVeyor gives me, just to make sure.

Smaug123 commented 4 months ago

Hmm: https://github.com/dotnet/sourcelink/blob/a22426a46745b8fe77b9d306fa4bc1d03eff44ea/README.md

If your project uses .NET SDK 8+ and is hosted by the above providers it does not need to reference any Source Link packages or set any build properties.

Smaug123 commented 4 months ago

Yeah, I seem to get that behaviour even without a reference to SourceLink, so I think this should Just Work (TM).

Smaug123 commented 4 months ago

It wouldn't be the dotnet CLI and msbuild/NuGet without nondeterministic and inconsistent behaviour - there's a solid chance this just doesn't work (https://github.com/dotnet/sdk/issues/16325#issuecomment-916297293 for example) and we may simply have to wait for an SDK bump after this goes in.

kurtschelfthout commented 4 months ago

Progress:

image