search

fschneidereit / VSEssentials

A free and open source collection of Visual Studio® extensions and utilities.
MIT License
10 stars 1 forks source link

CommentFormatter (and possibly others) does not italicize all fonts #3

Open delasteve opened 6 years ago

delasteve commented 6 years ago

Problem: Some fonts of the same family aren't rendering properly when enabling italicize comments. With the lack of being able to select font weight (as with VSCode editor.fontWeight property), one must select the font at the proper weight. I believe this is causing issues with this extension.

Expected: All fonts are able to be italicized if the family supports it.

System Info: Extension Version: 2017.1.1 OS: Windows 10 Pro, 10.0.17134 Build 17134 IDE: VS 2017 Professional

The following fonts work as expected:

The following fonts do not work as expected:

I'm happy to help in testing this, please let me know how! Fair warning, I've never worked on VS Extension Development.

fschneidereit commented 6 years ago

Since the extension uses standard Visual Studio APIs (IClassificationFormatMap and TextFormattingRunProperties) to apply the formatting, I'm not sure if anything can be done to solve this issue. It's implemented in the ClassificationFormatter class.