search

fschultz / NetImageLibrary

Library to help with image handling such as resizing, cropping, applying filters (brightess, contrast, unsharpen mask, chroma key etc), watermarking, thumbnail creation, opening/saving files or streams and more.
http://kaliko.com/image-library/
Other
90 stars 27 forks source link

Add support for .netStandard 2.0 #17

Closed rbrian closed 5 years ago

rbrian commented 6 years ago

i'm working on a Xamarin Forms project which requires the use of .netStandard 2.0 in one library. I made changes to support it, mainly removing the http streaming functions, as things like HttpContext and HttpResponse don't exist in .netStandard in the same way they do in .net 2.0. I tried to find workarounds, but wasn't successful so far. Would take major refactoring of the save* methods to accomplish it.

fschultz commented 6 years ago

Thank you very much for the pull request! I apologize for the late reply.

I will initially merge this to a local branch and start working on bringing this library fully up to .NET Standard/Core compatibility. I'm aiming for this to be a 4.0 release since as you say it will require alot of refactoring as well as replacing GDI+ functions and will update this thread with the progress.

fschultz commented 5 years ago

Thanks once again for the pull request! The develop branch is now updated to be compatible with .NET 4.x, Core 2.x and Standard 2.x. Once the new version is tested and considered stable it will be merged into master as version 4.0.

rbrian commented 5 years ago

You're welcome! Glad I could help. Also glad that I can start using the regular branch soon :)

brian

On Sun, May 26, 2019 at 12:42 AM Fredrik Schultz notifications@github.com wrote:

Thanks once again for the pull request! The develop branch is now updated to be compatible with .NET 4.x, Core 2.x and Standard 2.x. Once the new version is tested and considered stable it will be merged into master as version 4.0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fschultz/NetImageLibrary/pull/17?email_source=notifications&email_token=AABE736AJWKVQBFZ3JQEHP3PXI5M7A5CNFSM4FQAV37KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIAHQY#issuecomment-495977411, or mute the thread https://github.com/notifications/unsubscribe-auth/AABE73Y4OYJ3BSHBNRQLMBLPXI5M7ANCNFSM4FQAV37A .

-- Brian