search

fschutt / printpdf

A fully-featured PDF library for Rust, WASM-ready
https://fschutt.github.io/printpdf/
MIT License
829 stars 98 forks source link

PartialEq implementation of Mm fails for zero #137

Closed jannschu closed 1 year ago

jannschu commented 1 year ago

Hi,

this fails:

assert_eq!(Mm(0.), Mm(0.);

The issue is that in impl_partialeq the check is_normal returns false for zero.

JulienSchminke commented 1 year ago

Hi, I have fixed the bug. So I need to know how to push that to this repo now. This is my first contribution on an open source project.

May I get some help how to do now?

Thanks :D

jannschu commented 1 year ago

Thanks for working on this @JulienSchminke! :-)

JulienSchminke commented 1 year ago

No Problem :D

I think we can close this issue after upload

JulienSchminke commented 1 year ago

Hey, my solution is merged now. So we can close this issue now.