search

fschutt / printpdf

An easy-to-use library for writing PDF in Rust
https://docs.rs/printpdf/
MIT License
777 stars 95 forks source link

documenation is not updated with the changes in v 0.6.0 #154

Open LiamPClancy opened 9 months ago

LiamPClancy commented 9 months ago

Not sure how the readme file is generated?

but it's still showing the old process for adding lines on crates.io

and I can see in the repo the readme file still has

let line1 = Line { points: points1, is_closed: true, has_fill: true, has_stroke: true, is_clipping_path: false, };

and

current_layer.add_shape(line1);

but after upgrading to v0.6.0

it should be

let line1 = Line { points: points1, is_closed: true };

current_layer.add_line(line1);

assuming there might be other issues in the old file as well.

if it just needs manualy copying and pasting from the relevant files, i'm happy to make a PR, but thought i'd ask first incase it's build step that isn't running?

fschutt commented 9 months ago

It's not auto-generated, I need to update the README. I split the Line into Line and Polygon to make a distinction, so things like has_fill is useless.