search

fschutt / printpdf

A fully-featured PDF library for Rust, WASM-ready
https://fschutt.github.io/printpdf/
MIT License
829 stars 98 forks source link

add feature to make use of js-sys optional #162

Closed urlordjames closed 10 months ago

urlordjames commented 11 months ago

Resolves #157. This doesn't add a feature for reproducible output on all platforms, it's strictly for disabling js-sys on wasm.

urlordjames commented 11 months ago

I'm curious as to the rationale for re-implementing OffsetDateTime with js-sys instead of using time's implementation. I believe time has a wasm-bindgen feature that already implements the desired behavior right?

fschutt commented 10 months ago

I'm curious as to the rationale for re-implementing OffsetDateTime with js-sys instead of using time's implementation. I believe time has a wasm-bindgen feature that already implements the desired behavior right?

I probably didn't know about that feature at the time.