first version of facit - Githubissues

DanielFajardoJ commented 2 years ago

Work in progress on neoclassical analytical code FACIT. See upcoming paper by D. Fajardo et al. 2021

fsciortino commented 1 year ago

@odstrcilt The work on FACIT is effectively finished - many thanks to @DanielFajardoJ for his efforts to make this work! A few notes / outstanding issues:

The code in facit.py has been all benchmarked by Daniel; its results correspond to those in @DanielFajardoJ 's paper.
The script in examples/facit_basic.py shows how to run FACIT + give an example of how to use the D's and V's from FACIT into Aurora, which is a relatively trivial operation.
In order to run the rotation_model=2 (needed for impurities heavier than Ar), one needs to compute the R and V values along each flux surface. Daniel and I have compressed some of @odstrcilt 's routines to make a rhoTheta2RZ function in coords.py, but there is clearly some issue that we cannot figure out. @odstrcilt could you please have a look? Hopefully you can see the problem, having familiarity with the logic of that code. As far as I can see, there is an issue with the use of PSIRZ from the geqdsk dictionary, but I cannot see what. In the mapeq.py version for AUG shotfiles, the poloidal flux matrix (eqm.pfm) is used. This should be exactly the same as geqdsk['PSIRZ'], as far as I can tell... but somehow there's still an issue.
we may want to clean up the examples/facit_basic.py script a bit more.

Once the issue with rhoTheta2RZ is solved, we should be ready to merge, I think.

odstrcilt commented 1 year ago

The source code looks fine, I will try to run the example tomorrow and hopefully, it will work.

fsciortino commented 1 year ago

@odstrcilt did you get a chance to do some more testing? No worries if you need some time - @DanielFajardoJ is away for some time anyway, but it would be nice if we could conclude as soon as he's back.

odstrcilt commented 1 year ago

I have just tested that it works, but I have not compared the results with NEO by myself. I have read Daniel's paper. Once it will be in AURORA, I would like to use FACIT to calculate the W transport coefficient in the postprocessing step of OMFIT profiles, and I will add it also to the NEO module such that it will always be plotted together with NEO results.

DanielFajardoJ commented 1 year ago

Thank you both @fsciortino and @odstrcilt for all the support.

fsciortino / Aurora

first version of facit #44