fsciortino / Aurora

Modern toolbox for impurity transport, neutrals and radiation modeling in magnetically-confined plasmas
https://aurora-fusion.readthedocs.io
MIT License
34 stars 21 forks source link

Variety in Line Shapes #85

Open cjperks7 opened 1 year ago

cjperks7 commented 1 year ago

Due to my various needs, I would like there to be more flexibility available in aurora.radiation.get_local_spectrum(). I nominate myself to address these needs on appropriate branches to be reviewed by @fsciortino .

NOTE: In my efforts, I will be heavily relying on functions and data files from the Flexible Atomic Code (FAC, https://github.com/flexible-atomic-code/fac). This is because it can satisfy missing components to my needs not covered under OpenADAS. FAC may therefore become a hidden dependency when utilizing specific upgrades I need. Care would be taken for a more general user to have options to avoid this when possible.

Issue

Currently, only Doppler broadening is available for the line shape. I would like to convolute other shape due to other physics.

Motivation

Plan of Action

@fsciortino any opinions?

fsciortino commented 1 year ago

Hey @cjperks7 , this all sounds great! Strong encouragement from my side. Only concern: please try not to make your code specific to one application or another, but keep it general for other users. I know of several people across institutions who may be interested in these developments and could contribute at some point!

Worth mentioning: one challenge is to make the code efficient. If you do something super detailed, but it takes minutes to run, it may be good, but would have different applications. What is currently in Aurora isn't optimized for many calculations and line-integrals, but gives the gist of it (the more optimized version was used for BITS for C-Mod analysis, you might remember).

cjperks7 commented 1 year ago

@fsciortino, I understand the concerns you point out under all my posts. I will be clear with providing minimum working examples so that you can quickly see progress yourself and provide feedback on flexibility.

This will probably be an ongoing enhancement for a while before PR as I work on other physics in parallel (as always...) so hopefully you can review at your leisure.

FYI I have thought about using BITS to see what its basis functions would say about suprathermal ion features. Down the line though

cjperks7 commented 1 year ago

As I work on this, feel free to point whatever collaborators you're thinking of my way if you ever get the chance. More people with eyes on this can assure flexibility.

cjperks7 commented 1 year ago

@fsciortino Can I get write access to the Aurora repo?

Screenshot 2023-08-03 at 11 25 06 AM
fsciortino commented 1 year ago

@cjperks7 done!

cjperks7 commented 1 year ago

Thank you very much!