minor bug in plotting example in facit.py

fsciortino / Aurora

Modern toolbox for impurity transport, neutrals and radiation modeling in magnetically-confined plasmas

https://aurora-fusion.readthedocs.io

MIT License

39 stars 22 forks source link

minor bug in plotting example in facit.py #89

Closed DanielFajardoJ closed 1 year ago

DanielFajardoJ commented 1 year ago

For the plots at the end, the convection variables were being called fct.Vz instead of fct.Vconv, which gave rise to an error of course, so I corrected this.

fsciortino commented 1 year ago

@DanielFajardoJ did you notice that this was failing in the build tests? It should not have been merged. I don't think that it can be "undone". Can you please try to look into why it's failing the build tests? This won't be easier, but I think that it's a good learning experience anyway.

DanielFajardoJ commented 1 year ago

@fsciortino I hadn't noticed, sorry. I will have a look. But it is surprising, because I made a new installation of Aurora (for the new IPP file systems) and then only changed two lines in facit.py, related to the example plot at the end, and didn't touch anything else. Is this causing trouble somewhere else?