search

fsciortino / Aurora

Modern toolbox for impurity transport, neutrals and radiation modeling in magnetically-confined plasmas
https://aurora-fusion.readthedocs.io
MIT License
41 stars 24 forks source link

Fix CI: teach setuptools that the build needs numpy #96

Closed eguiraud closed 7 months ago

eguiraud commented 8 months ago

Recent versions of setuptools need the build requirements to be specified in the pyproject.toml, see https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#build-system-requirement

Editable installs are still not working, so this patch temporarily disables them in order to bring the CI back to green. The issue with editable installs is tracked at #98.

eguiraud-pf commented 8 months ago

Ok so this fixes installation of the package except for --editable installations. I'll see what I can do about that :)

eguiraud commented 8 months ago

@fsciortino see new PR description: I propose to disable editable installs for now so you get a green CI back (although one that does not test editable installs, for now).

I'll propose a larger refactoring of the building of the fortran extension modules soon that should bring editable installs back.

eguiraud commented 8 months ago

...never mind, setting up the new build system took less than I expected, I think we can skip this step and directly discuss #99 .