fsd-nodejs / service-mw2

Node.js 全栈开发之 Midway.js 最佳实践
MIT License
221 stars 38 forks source link

feat(jaeger): using midway-component-jaeger #72

Closed waitingsong closed 3 years ago

waitingsong commented 3 years ago

also bump deps:

tkvern commented 3 years ago

@waitingsong 这个很棒,少了很多配置。要不直接集成到 midway 里面,@midwayjs/jeager 是不是更给力

waitingsong commented 3 years ago

@waitingsong 这个很棒,少了很多配置。要不直接集成到 midway 里面,@midwayjs/jeager 是不是更给力

https://github.com/midwayjs/midway/pull/1051 我这儿项目需要这个东东,等不及 midway 那边所以先发了个版用着。晚点我把那边的 PR 也更新下。

tkvern commented 3 years ago

@waitingsong 这个很棒,少了很多配置。要不直接集成到 midway 里面,@midwayjs/jeager 是不是更给力

midwayjs/midway#1051 我这儿项目需要这个东东,等不及 midway 那边所以先发了个版用着。晚点我把那边的 PR 也更新下。

中间件挂载还有些问题

waitingsong commented 3 years ago

@waitingsong 这个很棒,少了很多配置。要不直接集成到 midway 里面,@midwayjs/jeager 是不是更给力

midwayjs/midway#1051 我这儿项目需要这个东东,等不及 midway 那边所以先发了个版用着。晚点我把那边的 PR 也更新下。

中间件挂载还有些问题

你指的是 ci 的失败?

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (f923cc6) into master (5579126) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #72    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           37        33     -4     
  Lines          918       771   -147     
  Branches        85        63    -22     
==========================================
- Hits           918       771   -147     
Impacted Files Coverage Δ
src/config/config.default.ts 100.00% <ø> (ø)
src/config/config.local.ts 100.00% <ø> (ø)
src/config/config.unittest.ts 100.00% <ø> (ø)
src/configuration.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5579126...f923cc6. Read the comment docs.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication