search

fsek / app

Repository for the F-sek mobile application
MIT License
10 stars 1 forks source link

Links to contacts in the news feed #108

Open FredrikLastow opened 6 years ago

FredrikLastow commented 6 years ago

The links that go to different contacts in the app should be opened in contact.html and not external. That is, the links that look like "https://fsektionen.se/kontakter/x" should look like "contacts/x" instead. The class and target attributes should also be removed from this a-tag.

navro commented 6 years ago

Should the app go through all news and look for links? Or can we do this in a smarter way? Can we allow the user to open fsektionen.se links in the app?

FredrikLastow commented 6 years ago

It feels like there should be a better solution than looping through all the news in frontend and replacing this specific string. Exactly what that is, is beyond me. Maybe, as you say, you could redirect these links into the app somehow.

FredrikLastow commented 6 years ago

Generally, we should redirect users on their phones to the app if the page their visiting on the website exists in the app as well.

navro commented 6 years ago

I agree :smile: Do you know if that is possible on iOS? I know you can do it on Android

FredrikLastow commented 6 years ago

If I link my own facebook profile in messenger and open it it looks like this:

Bildlänk

navro commented 6 years ago

Is that in the browser? Then i suppose it can't open them automatically :unamused:

FredrikLastow commented 6 years ago

I don't know if we want to do something simillar, but I'm pretty sure that it works on ios too. If you google facebook and click m.facebook.com it opens the app and not in the website. However if you click on facebook.com the opens it in the browser and only shows a popup

FredrikLastow commented 6 years ago

That was from the messenger app, but it was more of an alternative example. Some users might like to use a web browser instead of downloading the app, so having a small popup might be enough. How does it work on android?

navro commented 6 years ago

You get a popup asking you if you want to open it in the app or in a browser. You selct one alternative and then click on "just this time" or "always"