fsek / app

Repository for the F-sek mobile application
MIT License
10 stars 1 forks source link

Add event timeline with introduction events #202

Closed davidkrantz closed 5 years ago

davidkrantz commented 5 years ago

This PR replaces the introduction matrix image in the introduction tab with a timeline with the introduction events. For this to work, PR "Add API endpoint for introduction matrix" is needed. These two PR:s together closes #190.

Some information about this PR:

davidkrantz commented 5 years ago

Looks good! I noticed that if you go to an event through the timeline, sign up and then go back the status text is not updated. It still says: "you're not signed up". Not very important and I don't know how easy of a fix this is so if you want to you can take a look at it!

Very cool changes!!!

Yes, it would be nice if the registration status could be updated. The event cards on the home tab also have this problem and I struggled with it when implementing them as well. I yet have not found a clean solution for this, but I will add an issue and get back to it later, see #204.