search

fserb / canvas2D

Update Canvas 2D API
Other
151 stars 25 forks source link

Adding layers to the explainer #23

Closed Juanmihd closed 3 years ago

Juanmihd commented 3 years ago

This PR adds the explainer for layers, it also does some refactor to the readme, to include a section of currently released changes on the spec.

Juanmihd commented 3 years ago

Fernando, I addressed the comments, could you take another look? Thanks!

fserb commented 3 years ago

@Kaiido I'm merging this as is, but I want to keep discussing it and see what we can do better.

Juanmihd commented 3 years ago

Hi @Kaiido, I'm sorry, when you reviewed this explainer, it was still in WIP, and I had some things wrong. Could you take a new look now? Thanks!

Kaiido commented 3 years ago

The new commit did answer all my questions, much clearer thanks, and I didn't spot any more typos in there ;-)

I will open an issue regarding the idea of a CanvasFilter model later this week, but I actually see that it would be about the same as the CanvasRecording proposal, that I somehow missed all this time, except that the renderLayer() would be more like a drawImage(), using whatever composition status the context is in for rendering. But once again, I'll try to develop this in its own issue during the week.