search

fsfe / reuse-action

A GitHub action to check repositories for REUSE compliance
https://reuse.software
55 stars 8 forks source link

Support to run on changed files only #13

Closed aparcar closed 2 years ago

aparcar commented 2 years ago

Adding this to a large code base is a bit difficult since there are just so many warning. Would it be possible to run the validation on changed files only?

mxmehl commented 2 years ago

I'm afraid the REUSE tool currently does not support this. We need the whole git context – gitignores, .reuse/dep5, .license files etc – for an evaluation. This becomes even trickier as soon as we add additional and flexibly locatable sources of information, currently under the working title "REUSE.yaml".

Feel free to make a suggestion in the reuse-tool repo, but I'm not so optimistic, sorry.

However, I am wondering why the current command does not suffice. Even the Linux kernel can be linted in a short timeframe (<1 - ~3 minutes), depending on the machine's power.

ewan-escience commented 4 months ago

However, I am wondering why the current command does not suffice. Even the Linux kernel can be linted in a short timeframe (<1 - ~3 minutes), depending on the machine's power.

For us, it's not about performance, but about semantics. When using this action in a pipeline, we don't want the pipeline to fail when existing files are not compliant, only when new files are not compliant (see e.g. this issue). Is there any chance this will be reconsidered?