search

fsfe / reuse-action

A GitHub action to check repositories for REUSE compliance
https://reuse.software
55 stars 8 forks source link

Remove `cmd`, use `args` instead #7

Closed carmenbianca closed 4 years ago

carmenbianca commented 4 years ago

Turns out args is a built-in variable that can be used to append arguments to a Docker command.

This change requires reuse >=0.10.0

Overrides #4, fixes #3

carmenbianca commented 4 years ago

I'll release v0.10.0 now to make this PR mergeable.

One remark, though. Currently, GitHub users can already do this:

steps:
...
  - name: Check REUSE compliance
    uses: docker://fsfe/reuse:latest
    with:
      args: lint

This action would allow a user to do this:

steps:
...
  - name: REUSE Compliance Check
    uses: fsfe/reuse-action@master
    with:
      args: lint

What's the difference here?

mxmehl commented 4 years ago

Since 0.10 is released, this is mergable as well, right? Just want to be on the safe side ;)

Regarding the difference: I see that there is not much difference, but if we ask people to install the action, we can add more action-specific features in later steps.

And it might well be that the mount of /github/workspace would not work as intended with first snippet you posted.

carmenbianca commented 4 years ago

Yes, this can be merged :) I can see the point of being able to update this later.