fsfe / reuse-tool

reuse is a tool for compliance with the REUSE recommendations.
https://reuse.software
368 stars 139 forks source link

comment: fix GNU ld and as files #1034

Closed Thannoy closed 1 week ago

Thannoy commented 1 week ago

comment: fix GNU as comment style (*.s)

As well described by sourceware website [1]: There are two ways of rendering comments to as:

We therefore better should use the C style comment instead of any single-line comment which can't fit every cases.

Wikipedia [2] provides a list of target-specific GNU as single-line comments:

Hash symbol is currently used, this PR make it /* */

comment: fix GNU ld comment style (*.ld)

As per documentation: "You may include comments in linker scripts just as in C: delimited by /* and */."

Link: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_chapter/ld_3.html#SEC6


Thannoy commented 1 week ago

Ping @monacofj for comments since this PR touches its recent PR #928 work targeting issue #927

monacofj commented 1 week ago

Ping @monacofj for comments since this PR touches its recent PR #928 work targeting issue #927

Thanks @Thannoy for the kind ping. Good call, I think C-style comment for .s files seems more appropriate than the x86-specific character.