Closed Thannoy closed 1 week ago
Ping @monacofj for comments since this PR touches its recent PR #928 work targeting issue #927
Ping @monacofj for comments since this PR touches its recent PR #928 work targeting issue #927
Thanks @Thannoy for the kind ping.
Good call, I think C-style comment for .s
files seems more appropriate than the x86-specific character.
comment: fix GNU as comment style (*.s)
As well described by sourceware website [1]: There are two ways of rendering comments to as:
/*
through the next*/
is a comment.We therefore better should use the C style comment instead of any single-line comment which can't fit every cases.
Wikipedia [2] provides a list of target-specific GNU as single-line comments:
Hash symbol is currently used, this PR make it
/* */
comment: fix GNU ld comment style (*.ld)
As per documentation: "You may include comments in linker scripts just as in C: delimited by
/*
and*/
."Link: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_chapter/ld_3.html#SEC6
changelog.d/<directory>/
.AUTHORS.rst
.[ ] Wrote tests.==> Don't think this desserves a new test[ ] Documented my changes in==> Don't think this desserves a docdocs/man/
or elsewhere.