Fix the REUSE.toml performance regression (+ do a whole lot of refactoring)

fsfe / reuse-tool

reuse is a tool for compliance with the REUSE recommendations.

https://reuse.software

399 stars 148 forks source link

Fix the REUSE.toml performance regression (+ do a whole lot of refactoring) #1047

Closed carmenbianca closed 1 month ago

carmenbianca commented 3 months ago

Fixes #1033

Relevant to https://github.com/fsfe/reuse-website/pull/85

This is my attempt at fixing #1033. It necessitates a whole lot more shuffling things around than I had anticipated.

[x] Added a change log entry in changelog.d/<directory>/.
[x] Added self to copyright blurb of touched files.
[x] Wrote tests.
[ ] My changes do not contradict the current specification.
[x] I agree to license my contribution under the licenses indicated in the changed files.

carmenbianca commented 3 months ago

I want to stop passing (root, include_submodules, include_meson_subprojects, vcs_strategy) everywhere. I'm going to see if I can turn that information into an interface of Project, so that I can just pass the object to global_licensing.

edit: I was not successful.

carmenbianca commented 3 months ago

There is a light contradiction with the spec: REUSE.tomls ignored by VCS are ignored by the tool.