search

fsfe / reuse-tool

reuse is a tool for compliance with the REUSE recommendations.
https://reuse.software
399 stars 148 forks source link

Copyright styles and merging #948

Closed garethsb closed 3 months ago

garethsb commented 6 months ago

Currently supported styles:

    "spdx": "SPDX-FileCopyrightText:",
    "spdx-c": "SPDX-FileCopyrightText: (C)",
    "spdx-symbol": "SPDX-FileCopyrightText: ©",
    "string": "Copyright",
    "string-c": "Copyright (C)",
    "string-symbol": "Copyright ©",
    "symbol": "©",

The first issue I encountered is that none of the _COPYRIGHT_PATTERNS match the spdx-c style, so --merge-copyrights is not effective. A small tweak to the first pattern is sufficient - would a PR be accepted?

Secondly, I've been asked to use the (even more redundant) style: "SPDX-FileCopyrightText: Copyright (c) "... Would a PR to add sdpx-string-c (etc.) be accepted?

Thanks!

carmenbianca commented 6 months ago

Hi @garethsb , thanks for opening the issue!

The answer is yes to both. Contributions for this would be very welcome.

sin-ha commented 5 months ago

Hi @carmenbianca can you PTAL #979 TIA

sin-ha commented 3 months ago

Pinging again @carmenbianca can you please take a look

sin-ha commented 3 months ago

Thanks a lot @carmenbianca any ideas on when this would be released?