fsgmhoward / CS2113T-pe

0 stars 0 forks source link

Weird index for "search in" #2

Open fsgmhoward opened 3 years ago

fsgmhoward commented 3 years ago

I understand that the index may be the index for the facility in its category. However, it does not make any sense to print it out here as it is expected to be the index of the item this list.

Screenshot: image.png

^ For example, instead of

1 (canteen1) is located at  (5.5, 6.6, N4-01-01)
2 (canteen2) is located at  (1.0, 1.0, N3-02-02)
1 (lectureTheater1) is located at  (25.5, 26.6, NS3-05-43)

Printing this would be more appropriate and intuitive:

1 (canteen1) is located at  (5.5, 6.6, N4-01-01)
2 (canteen2) is located at  (1.0, 1.0, N3-02-02)
3 (lectureTheater1) is located at  (25.5, 26.6, NS3-05-43)
nus-pe-bot commented 3 years ago

Team's Response

The index together with the name of the facilities are particularly used together to uniquely identify the facilities.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: There is already an index followed by the facility (e.g. the 1 behind canteen1). It does not make sense that the first number is also the index of this facility in its class. Perhaps it is designed this way but it makes users (like me) feel weird, at least it is not an intuitive way to do so.