search

fsgmhoward / CS2113T-pe

0 stars 0 forks source link

Wrong "Sequence Diagram for loading facility data" #8

Open fsgmhoward opened 3 years ago

fsgmhoward commented 3 years ago

I would assume that you want to represent the constructor here:

image.png

The correct notion should be like this instead:

image.png

Moreover, is there a missing arrow going back here?

image.png

Since the "control" has not been transferred back to the user and the activation bar has not terminate, I would assume that the execution is still at the :FileManager, so the user should not have a action pointing.

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since no reason provided, I would insist on my original opinion.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This is not a cosmetic bug so it should not be Very Low. It should not even be Low as this cause inconvenience for developers like me. I am not able to distinguish whether you call the function's constructor or in some other way. The control of the execution is also misleading without the return arrow.