search

fsharp / emacs-fsharp-mode

F# Emacs mode
Apache License 2.0
208 stars 62 forks source link

WIP: Adding new requirements for appveyor installation #226

Closed MiyamotoAkira closed 4 years ago

MiyamotoAkira commented 4 years ago

Start the process of getting the new cask/buttercup system running on appveyor

MiyamotoAkira commented 4 years ago

Tests running now. Four of them fail (also in local), and still have to fix that the end of the run should be based on the output of the commands

juergenhoetzel commented 4 years ago

Tests running now. Four of them fail (also in local), and still have to fix that the end of the run should be based on the output of the commands

Thanks for working on this :+1: I wonder why Appveyor reports succees. Do we need something like bash set -o pipefail here:

cask exec buttercup -L . -L (Join-Path (Split-Path $PSScriptRoot -parent) "test") | Out-String
MiyamotoAkira commented 4 years ago

Could be because of Out-String. Between today and tomorrow i should be able to get that sorted (he says hopefully), and then investigate the four failures

On Sat, 30 Nov 2019 at 10:03, Jürgen Hötzel notifications@github.com wrote:

Tests running now. Four of them fail (also in local), and still have to fix that the end of the run should be based on the output of the commands

Thanks for working on this 👍 I wonder why Appveyor reports succees. Do we need something like bash set -o pipefail here:

cask exec buttercup -L . -L (Join-Path (Split-Path $PSScriptRoot -parent) "test") | Out-String

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fsharp/emacs-fsharp-mode/pull/226?email_source=notifications&email_token=AA6NKAPV2JTUYR7SX2XS453QWI255A5CNFSM4JR52NP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQABJQ#issuecomment-559939750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6NKAO6ZVY6PQMIB6JNSZTQWI255ANCNFSM4JR52NPQ .

juergenhoetzel commented 4 years ago

Appveyor installation is obsoleted by the #249

The windows ci-job is a bad hack because of the cask-windows problems: Any support to improve it eldev is welcome :smile: