search

fsharp / emacs-fsharp-mode

F# Emacs mode
Apache License 2.0
206 stars 62 forks source link

fsharp-mode: do not explicitly depend on eglot #253

Closed kiennq closed 3 years ago

kiennq commented 3 years ago

Currently fsharp-mode takes a hard dependency on Eglot, which is not desirable when other LSP system (like lsp-mode) has been in used. Since user will need to take extra step of requiring eglot-fsharp, I think we should remove the dependency in header and instead let user install eglot and requiring eglot-fsharp by themselves

juergenhoetzel commented 3 years ago

Good point.

The melpa fsharp-mode package should also be changed (split to fsharp-mode and eglot-fsharp) to reflect these change. Otherwise the eglot dependency is still installed

kiennq commented 3 years ago

@juergenhoetzel Since I'm not package owner, I doubt I can just easily create a new MELPA package for eglot-fsharp, can you help with that?

juergenhoetzel commented 3 years ago

@juergenhoetzel Since I'm not package owner, I doubt I can just easily create a new MELPA package for eglot-fsharp, can you help with that?

Of course.I will do. The installation notes should also be updated.

juergenhoetzel commented 3 years ago

Merged via #263 (doc update): Thanks!