fsharp / emacs-fsharp-mode

F# Emacs mode
Apache License 2.0
206 stars 62 forks source link

Fixed for split eglot-fsharp package #260

Closed jcs090218 closed 3 years ago

jcs090218 commented 3 years ago

This patch fixed most issues from https://github.com/melpa/melpa/pull/7336.

juergenhoetzel commented 3 years ago

thanks for stepping in :+1:

I relaxed the Emacs version dependency to 26.3 (minimum required version for eglot).

The remaining package-lint error eglot-fsharp.el:157:9: error: You should depend on (emacs "27.1") if you need jsonrpc-error seems to be a false positive. The required jsonrpc library is installed as transitive dependency when using Emacs 26.3.

Dependency-Tree of 26.3:

fsharp-mode 1.9.15
    s 1.3.1    [1.12.0 installed]
    eglot (any)    [1.7 installed]
        jsonrpc 1.0.14