search

fsharp / emacs-fsharp-mode

F# Emacs mode
Apache License 2.0
208 stars 62 forks source link

fix: `//`-comments filled incorrectly (`//` not acting as prefix) #270

Closed Kazark closed 3 years ago

Kazark commented 3 years ago

The problem is described here. I haven't been writing much F# lately but I found that emacs-scala-mode has the same problem and this fix works well for it, so I thought I would submit it here too.

Kazark commented 3 years ago

I updated the PR to not use a hook based on comments I got on my corresponding Scala PR, and testing that furthered my understanding of how setq interacts with major modes.

juergenhoetzel commented 3 years ago

Thanks :+1:

I have only made one small adjustment: https://github.com/fsharp/emacs-fsharp-mode/commit/93b1fbc31d73286a18640a36fc2be87d1736e0f2 (Make adaptive-fill-regexp buffer-local )

Kazark commented 3 years ago

@juergenhoetzel Oh, yes, I see that would be necessary. Thanks!